[coreboot-gerrit] Change in coreboot[master]: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38780 )

Change subject: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... 
File src/security/vboot/bootmode.c:

https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... 
PS2, Line 65: 	if (get_recovery_mode_switch())
> Currently the assertion that would be triggered is inside vboot_get_context(): […]

No, I just meant we should directly call vboot_get_context() from all those functions depending on that, without worrying about vboot_logic_executed(). We want that assertion (I think it's fine as it is but feel free to update it as suggested if you prefer) to hit whenever someone calls those functions at a point where they shouldn't, rather than just return an incorrect value.