Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42074 )
Change subject: [WIP] soc/amd/common: Avoid MMIO aliasing on SMBus ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42074/10/src/soc/amd/common/block/s... File src/soc/amd/common/block/smbus/smbus.c:
https://review.coreboot.org/c/coreboot/+/42074/10/src/soc/amd/common/block/s... PS10, Line 15: union reg_bank { : uint8_t reg8[0x100]; : uint16_t reg16[0x100 / sizeof(uint16_t)]; : }; I'm clearly missing something. What aliasing? This seems really strange as well.
https://review.coreboot.org/c/coreboot/+/42074/10/src/soc/amd/common/block/s... PS10, Line 23: controller->reg8[reg]; read8()
https://review.coreboot.org/c/coreboot/+/42074/10/src/soc/amd/common/block/s... PS10, Line 29: controller->reg8[reg] = val write8()