Attention is currently required from: Felix Singer, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49201 )
Change subject: mb/google/parrot: Put trailing statement in the next line
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
According to our coding style [1], this time the linter is correct:
Don’t put multiple statements on a single line unless you have something to hide:
if (condition) do_this;
do_something_everytime;
[1]: https://doc.coreboot.org/coding_style.html#indentation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f74f25cb2e3edcdd509abd86d80098241c05741
Gerrit-Change-Number: 49201
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 07 Jan 2021 20:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment