11 Feb
2019
11 Feb
'19
8:03 a.m.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )
Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31328/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31328/1/src/mainboard/google/hatch/variants/... PS1, Line 30: /* TRACKPAD_INT_ODL */
Can you please add a comment indicating that this is a temporary work-around and should be removed o […]
Ok. Done. Please review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Gerrit-Change-Number: 31328
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Mon, 11 Feb 2019 08:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment