Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39128 )
Change subject: soc/intel/icelake: Add function to dump ME firmware status information ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39128/7/src/soc/intel/icelake/me.c File src/soc/intel/icelake/me.c:
https://review.coreboot.org/c/coreboot/+/39128/7/src/soc/intel/icelake/me.c@... PS7, Line 125: BIOS_DEBUG I’d suggest `BIOS_INFO`.
https://review.coreboot.org/c/coreboot/+/39128/7/src/soc/intel/icelake/me.c@... PS7, Line 126: hfsts1.data); This line should fit in 96 characters.