Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45778 )
Change subject: soc/intel/cannonlake: Align cosmetics with Ice Lake ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45778/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45778/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/cannonlake: Align cosmetics with Ice Lake
Even I like the changes, I wouldn't compare with another SoC (Why this SoC?) and I think this doesn' […]
Good question. This is merely to reduce non-functional differences between both SoCs, which improves the SNR of diff tools. I chose to change cannonlake just because it would not result in a Jenkins complaint on sd.c (about the asterisk).
Gave a reason in the commit message.