View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: soc/intel/cannonlake: Align cosmetics with Ice Lake
Even I like the changes, I wouldn't compare with another SoC (Why this SoC?) and I think this doesn' […]
Good question. This is merely to reduce non-functional differences between both SoCs, which improves the SNR of diff tools. I chose to change cannonlake just because it would not result in a Jenkins complaint on sd.c (about the asterisk).
Gave a reason in the commit message.
To view, visit change 45778. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9f882f9f8af1245e937b0d47bc7e993547365f
Gerrit-Change-Number: 45778
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 12 Oct 2020 14:37:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Gerrit-MessageType: comment