[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add pmic MT6359P driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45399 )

Change subject: soc/mediatek/mt8192: add pmic MT6359P driver
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... 
File src/soc/mediatek/mt8192/mt6359p.c:

https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... 
PS1, Line 307: mt6359p_read_field
I think we can create generic functions for these, say

u32 pmif_read_field(struct pmif *arb, u32 slave_id, u32 reg, u32, mask,u32 shift)
 {
  ..
 }

So you don't need to declare these read/write field functions everywhere.