Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't en MAX98357A in dt ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@7 PS3, Line 7: en
enable
I just did this to keep the short msg short, however done.
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@9 PS3, Line 9: doesn't have this packed
does not have these speaker amps, so don't ...
Done
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@14 PS3, Line 14: wont
won't
Done
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@14 PS3, Line 14: base
base -> baseboard (?)
Done
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... PS3, Line 6: DRIVERS_I2C_DA7219
Or maybe just leave these enabled? Does it really matter if they are enabled in KConfig but not use […]
I assume you are referring to the line before?
It MAX98.. allegedly does get it's fill_ssdt fn ptr called if any devicetree bits are in the baseboard dt config because devicetree override doesn't properly override children.
If we want to go that route I short revive the earlier patch that moves it completely out of the baseboard however that is a little more invasive.