Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig...
PS1, Line 65: The FP5 supports higher-wattage parts and dual DDR-4 memory
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig...
PS1, Line 70: The FT5 supports low-power parts and single-channel DDR-4
Please add a dot/period at the end of sentences.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4663d38f1824786f14b6aa000adf27d64e70b5f
Gerrit-Change-Number: 39867
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Mar 2020 20:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment