Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )
Change subject: soc/mediatek/mt8196: Add tracker driver
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
Patchset:
PS8:
Thank you. Feel free to mark comments as done yourself in the future.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84929/comment/15629bbd_6a95925f?usp... :
PS1, Line 9: include
including
Done
https://review.coreboot.org/c/coreboot/+/84929/comment/5d291ece_a2b4d350?usp... :
PS1, Line 10: latches some
: values which could be used for debug
How can this be used? It’d be great if you elaborated?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84929?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib9784a370acec45ce36a800f3955b9cf96651298
Gerrit-Change-Number: 84929
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 07 Nov 2024 18:56:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org