Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44117 )
Change subject: mb/google/volteer/*/gpio.c: add GPP_D16 to early_gpio_table
......................................................................
Patch Set 1:
Patch Set 1:
This is missing changes for baseboard, Halvor, and Trondo. They each export their own early_gpio_table under certain conditions.
what changes would you like to see for those boards?
if GPP_D16 is not listed in gpio_table[] or a no-connect,
then it should not need to be in early_gpio_table[].
trondo GPIO definitions are still WIP,
to there's nothing to update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf5e770f540e5d1e27b40f270bb004f4196bc7be
Gerrit-Change-Number: 44117
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 06:45:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment