Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
Patch Set 3:
Let's just change this:
https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/octo...
to
PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_WLAN_L */
so that the default configuration is active low and IOStandby for EN_PP3300_WLAN_L and then remove GPIO_178 completely from the default_override_table for following variants: bloog bobba fleex meep phaser
Ampton has another issue, it has the polarity incorrect. Let me file a separate bug for that, but let's make the above change for rest of the boards.
yorp and bip have active high enable so let's leave their configuration as is.