Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: payloads/tianocore: Enable UEFIPayload ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34459/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34459/9//COMMIT_MSG@14 PS9, Line 14: PCIE_BASE set.
Because MMCONF_BASE_ADDRESS is not always set
but if it is, we need to pass it in/set it for UefiPayloadPkg to work, no? we can't have the default cause be non-working for the majority of devices likely to use the payload
https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... PS9, Line 27: select TIANOCORE_REVISION change to newly-added TIANOCORE_MASTER per below?
https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... PS9, Line 39: I'd add another option here:
config TIANOCORE_MASTER bool "master" depends on TIANOCORE_UEFIPAYLOAD
https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... PS9, Line 42: depends on TIANOCORE_UEFIPAYLOAD this should be removed, both payload options should be able to set a specific revision
https://review.coreboot.org/c/coreboot/+/34459/9/payloads/external/tianocore... PS9, Line 45: from MrChromebox's tree remove this since either tree/any branch can be used