Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47189 )
Change subject: mb/purism_librem_mini: Add child device, slot descriptions to PCIe RPs ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
Patch Set 1:
Can we split a devices and slot descriptions, please?
I'm not sure what you're asking for exactly
I just realized the devices are M.2 slots (sorry, it's late :S). The LAN dev could go to a separate commit, though
https://review.coreboot.org/c/coreboot/+/47189/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47189/1/src/mainboard/purism/librem... PS1, Line 218: device pci 00.0 on end # x1 (LAN) nit: this could be a separate commit