Attention is currently required from: Mike Banon. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32352 )
Change subject: configs: add Lenovo G505S sample configuration (use with dGPU patches) ......................................................................
Patch Set 38: Verified-1
(6 comments)
File configs/config.lenovo_g505s_use_with_dgpu_patches:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137389): https://review.coreboot.org/c/coreboot/+/32352/comment/83a95702_84057ff1 PS38, Line 380: # CONFIG_SUPERIO_ASPEED_AST2400 is not set 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137389): https://review.coreboot.org/c/coreboot/+/32352/comment/b19962ed_c3b50bf9 PS38, Line 381: # CONFIG_SUPERIO_ASPEED_COMMON_PRE_RAM is not set 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137389): https://review.coreboot.org/c/coreboot/+/32352/comment/cd118a8a_87e7b4f8 PS38, Line 382: # CONFIG_SUPERIO_ASPEED_HAS_UART_DELAY_WORKAROUND is not set 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137389): https://review.coreboot.org/c/coreboot/+/32352/comment/24b497dd_4cb7b17f PS38, Line 383: # CONFIG_SUPERIO_FINTEK_FAN_CONTROL is not set 'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137389): https://review.coreboot.org/c/coreboot/+/32352/comment/a4d72bf5_5bf28d23 PS38, Line 545: # CONFIG_SPI_FLASH_DONT_INCLUDE_ALL_DRIVERS is not set 'DONT' may be misspelled - perhaps 'DON'T'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137389): https://review.coreboot.org/c/coreboot/+/32352/comment/13e61b94_2289e463 PS38, Line 558: CONFIG_NO_UART_ON_SUPERIO=y 'SUPERIO' may be misspelled - perhaps ''?