Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37291 )
Change subject: nb/intel/x4x: Factor out hiding PCI devs in pure fn
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37291/1/src/northbridge/intel/x4x/n...
File src/northbridge/intel/x4x/northbridge.c:
https://review.coreboot.org/c/coreboot/+/37291/1/src/northbridge/intel/x4x/n...
PS1, Line 230: for (dev = 6; dev > 0; dev--) {
I'm not even sure if a loop is even useful at this point. This is actually a sequence of four instructions:
hide_pci_dev(6, 0, 13);
hide_pci_dev(3, 3, 6);
hide_pci_dev(2, 1, 3);
hide_pci_dev(1, 0, 1);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64db2460115f5fb35ca197b83440f8ee47470761
Gerrit-Change-Number: 37291
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:45:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment