Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38370 )
Change subject: arch/x86/post.c: Hide cmos_post_code from SMM context
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38370/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38370/2//COMMIT_MSG@7
PS2, Line 7: rtc/post.c: Fix compilation issue for post.c
Too generic. Maybe: […]
Ack
https://review.coreboot.org/c/coreboot/+/38370/2//COMMIT_MSG@10
PS2, Line 10: function in smm stage.
What is the error?
Done
https://review.coreboot.org/c/coreboot/+/38370/2//COMMIT_MSG@14
PS2, Line 14: caller function to resolve the issue
It looks like this is the only remaining change?
Yes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffdcccaad48e7ad96e068d07046630fbe4297e65
Gerrit-Change-Number: 38370
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jan 2020 16:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment