HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )
Change subject: fw_config: Add firmware configuration interface ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@2 PS4, Line 2: /* This file is part of the coreboot project. * please remove
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@8 PS4, Line 8: #include <types.h> this is not used.
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@9 PS4, Line 9: #include <static.h>
there is an odd build dependency issue where sometimes the sconfig step doesn't happen at the start […]
maybe <device/device.h> is missing in one of you files ? (or <smbios.h>)
in any case, "#include <static.h>" is not used here :)
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@2 PS4, Line 2: /* This file is part of the coreboot project. */ please remove
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@6 PS4, Line 6: #include <cbfs.h> not used?
(please check the other includes)
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@11 PS4, Line 11: #include <string.h> not used
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@12 PS4, Line 12: #include <types.h> not used?