Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41630 )
Change subject: soc/amd/picasso: rewrite soc_util
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41630/7/src/soc/amd/picasso/soc_uti...
File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/41630/7/src/soc/amd/picasso/soc_uti...
PS7, Line 149: break;
break is not useful after a goto or return
sure. I'll keep this one though so things won't possibly misbehave when checks or more SoC types with FT5 socket get added here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I589be3bdac4b94785e6ecacf55235be4ad5673d9
Gerrit-Change-Number: 41630
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 May 2020 00:37:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment