[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/pcie/rtd3: Make changes to support S3

[Furquan Shaikh (Code Review)]

Attention is currently required from: Tim Wawrzynczak, Duncan Laurie.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48682 )

Change subject: soc/intel/common/block/pcie/rtd3: Make changes to support S3
......................................................................

Patch Set 2: -Code-Review

(1 comment)

File src/soc/intel/common/block/pcie/rtd3/rtd3.c:

https://review.coreboot.org/c/coreboot/+/48682/comment/70a9f421_6b793175 
PS2, Line 91: /* Ensure check works for both active low and active high GPIOs. */
            : 	acpigen_write_store_int_to_op(gpio->active_low, LOCAL1_OP);
            : 
            : 	acpigen_write_if_lequal_op_op(LOCAL0_OP, LOCAL1_OP);
            : 	acpigen_write_store_int_to_op(0, LOCAL0_OP);
            : 	acpigen_pop_len(); /* If */
            : 	acpigen_write_else();
            : 	acpigen_write_store_int_to_op(1, LOCAL0_OP);
            : 	acpigen_pop_len(); /* Else */
> doesn't acpigen_get_tx_gpio already take care of the polarity inversion?

You are right. It does.