Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Jan Samek, Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email )
Change subject: doc/Makefile: Fix build dir setting
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
It seems it already worked before...
@Felix Singer: Before commit 4d8da8ed, running something like `make sphinx BUILDDIR=my_build_dir` in the Documentation already seems to override any BUILDDIR variable in the Makefiles. So I guess the question is why we are fixing a change that may not have been needed in the first place.
According to https://www.gnu.org/software/make/manual/html_node/Overriding.html, command line arguments override any ordinary assignments in the Makefile (despite not using `?=`)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75893?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3
Gerrit-Change-Number: 75893
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 17 Jun 2023 00:10:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
