Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38282 )
Change subject: mb/google/dedede: Enable EC ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... PS8, Line 3: EC_ACPI
Why is this required?
My bad. Not required.
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/ec.c:
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... PS8, Line 31: bootblock_ec_init
I don't think this function will be required. […]
Sure, will remove it.
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... PS8, Line 23: mainboard_ec_init
In the past, this has been done in the dev->init instead of chip->init. See hatch as example.
Just curious if there is a dependency reason that it moved to dev->init because in octopus it was done in chip->init.