Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55660 )
Change subject: mb/purism/librem_mini/hda_verb.c: Fix subsystem, jack detect ......................................................................
mb/purism/librem_mini/hda_verb.c: Fix subsystem, jack detect
- set subsystem/subvendor ID to Realtek default, as the one dumped from the vendor UEFI firmware provides no advantages - Add a codec reset before setting the subvendor ID using the Azalia macro for consistency with all other Realtek HDA codecs - disable jack detect for the external mic on the 3.5mm jack, since it's not currently working, so that the external microphone can be manually selected
Change-Id: Ib0f99e5088973a721c0a295899012c9aea5009cf Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/55660 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c 1 file changed, 7 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c index 93dd270..5a9aead 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c @@ -3,16 +3,18 @@ #include <device/azalia_device.h>
const u32 cim_verb_data[] = { - 0x10ec0269, /* Codec Vendor/Device ID: Realtek ALC293 */ - 0x10ec0000, /* Subsystem ID */ - 11, /* Number of entries */ + 0x10ec0269, /* Codec Vendor/Device ID: Realtek ALC269 */ + 0x10ec0269, /* Subsystem ID */ + 12, /* Number of entries */
- AZALIA_SUBVENDOR(0, 0x10ec0000), + AZALIA_RESET(0x1), + + AZALIA_SUBVENDOR(0, 0x10ec0269), AZALIA_PIN_CFG(0, 0x12, 0x411111f0), /* NC */ AZALIA_PIN_CFG(0, 0x14, 0x411111f0), /* NC */ AZALIA_PIN_CFG(0, 0x15, 0x02211010), /* Jack analog out */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0), /* NC */ - AZALIA_PIN_CFG(0, 0x18, 0x02a11020), /* Jack analog mic */ + AZALIA_PIN_CFG(0, 0x18, 0x02a11120), /* Jack analog mic, no presence detect */ AZALIA_PIN_CFG(0, 0x19, 0x411111f0), /* NC */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), /* NC */ AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* NC */