Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38664 )
Change subject: mb/intel/glkrvp: Simplify FMAP file
......................................................................
Patch Set 1:
I don't necessarily understand the impetus for this change. While it happens to be the case that the regions here are continuous, there's no guarantee that will always be the case. And removing the start address for each region just makes it harder to calculate the absolute position of any given region if needed, and even moreso when we get to 3 and 4 layers of nesting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac1d1e16be5db7bfbadc5929057cc2d93b5cd876
Gerrit-Change-Number: 38664
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 18 Feb 2020 02:40:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment