build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33400 )
Change subject: util/amdfwtool: Update for Family 17h ......................................................................
Patch Set 3:
(18 comments)
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@202 PS3, Line 202: printf("-U | --token-unlock Reserve space for debug token\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@207 PS3, Line 207: printf("-I | --instance <number> Sets instance field for the next BIOS firmware\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@208 PS3, Line 208: printf("-a | --apcb <FILE> Add AGESA PSP customization block\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@209 PS3, Line 209: printf("-Q | --apob-base <HEX_VAL> Destination for AGESA PSP output block\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@212 PS3, Line 212: printf("-y | --pmu-inst <FILE> Add PMU firmware instruction portion\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@213 PS3, Line 213: printf("-G | --pmu-data <FILE> Add PMU firmware data portion\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@216 PS3, Line 216: printf("-V | --bios-bin <FILE> Add compressed image; auto source address\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@217 PS3, Line 217: printf("-e | --bios-bin-src <HEX_VAL> Address in flash of source if -V not used\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@218 PS3, Line 218: printf("-v | --bios-bin-dest <HEX_VAL> Destination for uncompressed BIOS\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@219 PS3, Line 219: printf("-j | --bios-uncomp-size <HEX> Uncompressed size of BIOS image\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@838 PS3, Line 838: printf("Error: APOB NV address provided, but no size\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@856 PS3, Line 856: printf("Error: BIOS binary destination and uncompressed size are required\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@861 PS3, Line 861: printf("Error: BIOS binary assumed outside amdfw.rom but no source address given\n"); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@886 PS3, Line 886: biosdir->entries[count].source = fw_table[i].src; line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@890 PS3, Line 890: ctx->current = ALIGN(ctx->current, ERASE_ALIGNMENT); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@891 PS3, Line 891: biosdir->entries[count].source = RUN_CURRENT(*ctx); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@893 PS3, Line 893: fw_table[i].size, ERASE_ALIGNMENT); line over 80 characters
https://review.coreboot.org/#/c/33400/3/util/amdfwtool/amdfwtool.c@975 PS3, Line 975: static const char *optstring = "x:i:g:AMS:p:b:s:r:k:c:n:d:t:u:w:m:T:z:J:B:K:L:Y:N:UW:I:a:Q:V:e:v:j:y:G:O:X:F:H:o:f:l:h"; line over 80 characters