Attention is currently required from: Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74277 )
Change subject: mb/google/myst: Enable mp2 device
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74277/comment/8b5b5888_e9231ff0
PS4, Line 115: device ref mp2 on end # Sensor Fusion Hub (MP2)
This is the wrong file, since you've updated `skyrim`, not `myst`.
See "ref1" below.
https://review.coreboot.org/c/coreboot/+/74277/comment/5c0a8142_cdcd211e
PS4, Line 167: device ref mp2 on end # Sensor Fusion Hub (MP2)
ref1: It's already defined here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74277
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21885c51ff08846b456675090946f381843ef5e6
Gerrit-Change-Number: 74277
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 16:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment