Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28925 )
Change subject: mb/google/kahlee: Don't set stapm parameters
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28925/1/src/mainboard/google/kahlee/variants...
File src/mainboard/google/kahlee/variants/careena/devicetree.cb:
https://review.coreboot.org/#/c/28925/1/src/mainboard/google/kahlee/variants...
PS1, Line 25: # register "stapm_percent" = "68
From the way code is set, just commenting 1 parameter would have the same effect. Commenting them all is clearer though.
--
To view, visit
https://review.coreboot.org/28925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2299ab81fcc2af0529bfac3be562b05116c64a49
Gerrit-Change-Number: 28925
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Oct 2018 20:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes