Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46432/2/src/security/vboot/antiroll... File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/46432/2/src/security/vboot/antiroll... PS2, Line 27: MRC_ Why did we add MRC_ to this? I think we should be consistent with REC_HASH_NV_INDEX and MRC_RW_HASH_NV_INDEX.
REC_MEM_HASH_NV_INDEX NORM_MEM_HASH_NV_INDEX or RW_MEM_HASH_NV_INDEX
Also, we should probably add a comment explaining what is stored at these indicies.
It looks like Julius commented something similar. I suggest we align the names, but that can be in a follow up.