Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31141 )
Change subject: string: move strdup() & strconcat() to lib/string.c
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
If you ask me we should move more than this... everything but the ctype (isXXX() and toXXX()) stuff.
All code which doesn't call memXXX() can be shared between rom and ram stage. Moving strdup() and strconcat() into a separate file and leaving the rest in string.h is the easiest way to get it working.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b9833fbf6742d110ee4bfc00cd650f219aebb2c
Gerrit-Change-Number: 31141
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:10:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment