[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/dedede: Initial fw_config configuration setting

[Paul Menzel (Code Review)]

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email )

Change subject: mb/google/dedede: Initial fw_config configuration setting
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79930/comment/09ad8046_327cf955 :
PS4, Line 7: Initial fw_config configuration setting
Please make it a statement by using a verb (in imperative mood). Maybe:
> Configure …

or
> Add initial …

https://review.coreboot.org/c/coreboot/+/79930/comment/82893159_4fe84fb7 :
PS4, Line 9: 1.Describe
Please add a dot after the enumeration number(?).

https://review.coreboot.org/c/coreboot/+/79930/comment/13c77cb1_1f7d45bd :
PS4, Line 10: - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF
            : - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW
As this belongs to item one, please indent by four spaces.

File src/mainboard/google/dedede/variants/pirika/variant.c:

https://review.coreboot.org/c/coreboot/+/79930/comment/71756079_bec86700 :
PS4, Line 14: 0x350000
Where is this number from?