build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming [Patch 2 of 3] ......................................................................
Patch Set 1:
(139 comments)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 32: uint32_t dual_dsi, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 32: uint32_t dual_dsi, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 36: uint32_t broadcast); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 48: uint32_t ctl_base, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 49: uint32_t sctl_base) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 49: uint32_t sctl_base) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 74: "Panel CMD: count :%d command mode dma test failed\n",count); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 109: printk(BIOS_ERR,"Panel CMD: Did not receive video mode done""interrupt\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 109: printk(BIOS_ERR,"Panel CMD: Did not receive video mode done""interrupt\n"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 109: printk(BIOS_ERR,"Panel CMD: Did not receive video mode done""interrupt\n"); Consecutive strings are generally better as a single string
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 116: printk(BIOS_INFO,"Panel wait_4_video_done: Received video mode done ack\n"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 125: struct mipi_dsi_cmd *cmds, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 160: cm = cmds; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 160: cm = cmds; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 190: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 249: uint32_t **rp, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 249: uint32_t **rp, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 250: int rp_len, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 250: int rp_len, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 251: int rdbk_len) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 311: uint32_t dual_dsi) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 327: dual_dsi, uint32_t broadcast) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 369: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 369: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 386: | PACK_TYPE1 << 24 | VC1 << 22 | DT1 << 16 | WC1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 429: uint32_t uIntrStatusReg = readl(mipi->ctl_base + INT_CTRL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 432: uIntrStatusReg = HWIO_OUT_FLD(uIntrStatusReg, INT_CTRL, DSI_CMD_MODE_DMA_DONE_AK, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 435: uIntrStatusReg = HWIO_OUT_FLD(uIntrStatusReg, INT_CTRL, DSI_CMD_MODE_MDP_DONE_AK, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 438: uIntrStatusReg = HWIO_OUT_FLD(uIntrStatusReg, INT_CTRL, DSI_VIDEO_MODE_DONE_AK, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 441: uIntrStatusReg = HWIO_OUT_FLD(uIntrStatusReg, INT_CTRL, DSI_BTA_DONE_AK, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 443: uIntrStatusReg = HWIO_OUT_FLD(uIntrStatusReg, INT_CTRL, DSI_ERROR_AK, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 445: writel(uIntrStatusReg, mipi->ctl_base + INT_CTRL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 540: writel(((read_val & ~BIT(1)) | BIT(2)),ctl_base + CTRL); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 546: writel((read_val & ~BIT(0)),sctl_base + CTRL); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 559: pinfo->mipi.num_of_panel_off_cmds, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 560: pinfo->mipi.broadcast); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 565: uint32_t broadcast) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 565: uint32_t broadcast) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 584: mipi->panel_on_cmds, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 585: mipi->num_of_panel_on_cmds, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 600: uint16_t disp_width, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 601: uint16_t disp_height, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 602: uint16_t img_width, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 603: uint16_t img_height, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 604: uint16_t hsync_porch0_fp, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 605: uint16_t hsync_porch0_bp, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 606: uint16_t vsync_porch0_fp, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 607: uint16_t vsync_porch0_bp, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 608: uint16_t hsync_width, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 609: uint16_t vsync_width, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 610: uint16_t dst_format, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 611: uint16_t traffic_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 612: uint8_t lane_en, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 613: uint8_t pulse_mode_hsa_he, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 614: uint32_t low_pwr_stop_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 615: uint8_t eof_bllp_pwr, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 616: uint8_t interleav, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 617: uint32_t ctl_base) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 645: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 657: writel(low_pwr_stop_mode << 15 | eof_bllp_pwr << 12 | traffic_mode << 8 | dst_format << 4 | 0x0, line over 96 characters
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 697: printk(BIOS_INFO, "ctl_base=0x%08x, phy_base=0x%08x\n", mipi->ctl_base,mipi->phy_base); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 715: mipi->broadcast); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 764: pinfo->mipi.broadcast); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 773: uint16_t disp_width, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 774: uint16_t disp_height, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 775: uint16_t img_width, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 776: uint16_t img_height, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 777: uint16_t dst_format, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 778: uint8_t ystride, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 779: uint8_t lane_en, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 780: uint8_t interleav, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 781: uint32_t ctl_base) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 839: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 852: uRegVal = HWIO_OUT_FLD(uRegVal, COMMAND_MODE_MDP_DCS_CMD_CTRL, INSERT_DCS_COMMAND, 0x01); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 858: uRegVal = HWIO_OUT_FLD( uRegVal, COMMAND_MODE_DMA_CTRL, EMBEDDED_MODE, 0x01); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 859: uRegVal = HWIO_OUT_FLD( uRegVal, COMMAND_MODE_DMA_CTRL, POWER_MODE, 0x01); //Low power Mode line over 96 characters
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 859: uRegVal = HWIO_OUT_FLD( uRegVal, COMMAND_MODE_DMA_CTRL, POWER_MODE, 0x01); //Low power Mode space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 870: uint32_t uClkCtrlReg = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 873: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_AHBM_SCLK_ON, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 873: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_AHBM_SCLK_ON, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 874: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_FORCE_ON_DYN_AHBM_HCLK, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 874: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_FORCE_ON_DYN_AHBM_HCLK, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 877: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_PCLK_ON, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 877: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_PCLK_ON, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 880: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_AHBS_HCLK_ON, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 880: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_AHBS_HCLK_ON, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 881: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_DSICLK_ON, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 881: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_DSICLK_ON, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 883: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_BYTECLK_ON, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 883: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_BYTECLK_ON, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 884: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_ESCCLK_ON, 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 884: uClkCtrlReg = HWIO_OUT_FLD( uClkCtrlReg, CLK_CTRL, DSI_ESCCLK_ON, 1); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 886: writel(uClkCtrlReg, ctl_base + CLK_CTRL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... File src/soc/qualcomm/sc7180/display/dsi_panel_display.c:
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 28: struct lcdc_panel_info *plcdc); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 39: char *panel_destination) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 39: char *panel_destination) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 179: pstruct->paneldata->panel_destination); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 237: dsc->bpp = dsc_params->bpp; please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 337: pinfo->mipi.hsa_power_stop; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 340: final_width, final_height, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 342: final_hfp, final_hbp + final_hpw, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 343: final_vfp, final_vbp + final_vpw, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 344: final_hpw, final_vpw, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 345: pinfo->mipi.dst_format, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 346: pinfo->mipi.traffic_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 347: lane_enable, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 348: pinfo->mipi.pulse_mode_hsa_he, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 349: low_pwr_stop, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 350: pinfo->mipi.eof_bllp_power, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 351: pinfo->mipi.interleave_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 352: pinfo->mipi.ctl_base); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 356: final_width, final_height, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 357: final_xres, final_yres, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 358: final_hfp, final_hbp + final_hpw, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 359: final_vfp, final_vbp + final_vpw, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 360: final_hpw, final_vpw, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 361: pinfo->mipi.dst_format, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 362: pinfo->mipi.traffic_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 363: lane_enable, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 364: pinfo->mipi.pulse_mode_hsa_he, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 365: low_pwr_stop, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 366: pinfo->mipi.eof_bllp_power, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 367: pinfo->mipi.interleave_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 368: pinfo->mipi.sctl_base); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 381: uint32_t final_xres, final_yres, final_width; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 381: uint32_t final_xres, final_yres, final_width; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 410: final_xres, final_yres, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 411: pinfo->mipi.dst_format, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 412: ystride, lane_en, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 413: pinfo->mipi.interleave_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 414: pinfo->mipi.ctl_base); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 418: final_xres, final_yres, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 419: pinfo->mipi.dst_format, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 420: ystride, lane_en, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 421: pinfo->mipi.interleave_mode, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 422: pinfo->mipi.sctl_base); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 451: uint32_t supp_panels_size, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 451: uint32_t supp_panels_size, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39614/1/src/soc/qualcomm/sc7180/dis... PS1, Line 452: const char *panel_name) code indent should use tabs where possible