Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32405 )
Change subject: mb/google/kohaku: Update overridetree.cb ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32405/3/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/32405/3/src/mainboard/google/hatch/Kconfig@2... PS3, Line 25: DRIVERS_I2C_DA7219 It is fine to just select this up with other drivers. If this driver goes unused, it will be removed from the final image.
https://review.coreboot.org/#/c/32405/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32405/1/src/mainboard/google/hatch/variants/... PS1, Line 42: .rise_time_ns = 152, : .fall_time_ns = 30,
Sure, I just borrowed some numbers from another board w/ the same part for a starting point.
These numbers vary from board-to-board even if the same device is being used on the I2C bus. Its better to start with nothing here and update it later on.
https://review.coreboot.org/#/c/32405/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32405/3/src/mainboard/google/hatch/variants/... PS3, Line 21: register "sdcard_cd_gpio" = "" BTW I don't think this is going to work:
error: initialization of 'unsigned int' from 'const char *' makes integer from pointer without a cast [-Werror=int-conversion] .sdcard_cd_gpio = "",
You will have to move the sdcard_cd_gpio configuration in baseboard devicetree to hatch and hatch_whl overridetree.cb. It would be good to do that as a separate change and put it before this CL in the series.