Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36865 )
Change subject: mb/google/hatch: Override CPU flex ratio
......................................................................
Patch Set 9:
So, is it just the ratio that should be active while that vboot
code runs or is there another effect of flex ratio that helps here?
I'm asking because flex ratio seems to have some side effects that
might need more attention. And if just changing the frequency is
enough, we could just set a different speed-step state with a single
MSR write, no?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd1d1c0c04b1f742f17227a1335f27a956ee940d
Gerrit-Change-Number: 36865
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 Nov 2019 22:00:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment