Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40260 )
Change subject: soc/intel/common: Add method to modify GPIO community PM config
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40260/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40260/6//COMMIT_MSG@11
PS6, Line 11: configuraiton
configuration
Done
https://review.coreboot.org/c/coreboot/+/40260/6//COMMIT_MSG@15
PS6, Line 15: BUILD
Please be more specific.
Done
https://review.coreboot.org/c/coreboot/+/40260/6/src/soc/intel/common/acpi/g...
File src/soc/intel/common/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/40260/6/src/soc/intel/common/acpi/g...
PS6, Line 15: (
shouldn't need () here or in PCRO below
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac3a269d3071eb5d4100d516249eeb5ce23c02fa
Gerrit-Change-Number: 40260
Gerrit-PatchSet: 7
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Thu, 23 Apr 2020 00:05:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment