Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )
Change subject: soc/intel/tigerlake: Add Acoustic features ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45052/5/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/45052/5/src/soc/intel/tigerlake/chi... PS5, Line 153: /* : * VR domains. The domains are IA,GT,SA,VLCC and FIVR. : */ : enum { : VR_DOMAIN_IA, : VR_DOMAIN_GT, : VR_DOMAIN_SA, : VR_DOMAIN_VLCC, : VR_DOMAIN_FIVR, : VR_DOMAIN_MAX : } vr_domains; : : /* : * Slew Rate configuration for Deep Package C States for VR domain. : * They are fast time divided by 2. : * 0 - Fast/2 : * 1 - Fast/4 : * 2 - Fast/8 : * 3 - Fast/16 : */ : enum { : SLEW_FAST_2, : SLEW_FAST_4, : SLEW_FAST_8, : SLEW_FAST_16 : } slew_rate; : In addition to defining the enum values here, this also adds two (seemingly unused) fields called vr_domains and slew_rate to `struct soc_intel_tigerlake_config`. They can be defined outside of the structure (you already added FastPkgCRampDisable & SlowSlewRate)