Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33740 )
Change subject: Documentation: Update soc/intel/apollolake ......................................................................
Patch Set 7:
(9 comments)
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... File Documentation/soc/intel/apollolake/index.md:
PS3:
To me, this reads totally confusing now. Wouldn't it be worth to stick […]
Done
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 17: * Each LBP has its own copy of IFWI firmware components and OBB
Why mention OBB separately? I know most FMD files treat it like that, […]
Done
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... File Documentation/soc/intel/apollolake/index.md:
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 6: bios BIOS
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 19: extension expansion
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 35: \ / ?
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 44: (bootblock) They are all called bootblock somehow. Are you referring to the coreboot bootblock here? wouldn't that be the IBBL?
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 45: sub-partitions as specified in the FMAP. maybe add something like "Those are unknown to the IFWI structure." to make it clear that these are not LBP sub-partitions.
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 47: from IFWI OBB is part of an LBP, which is part of the IFWI. It doesn't start after the IFWI. Maybe just:
The OBB is always the last sub-partition of an LBP and spans to the end of the latter.
https://review.coreboot.org/c/coreboot/+/33740/7/Documentation/soc/intel/apo... PS7, Line 52: Instead we call the partition with the firmware components as "IFWI", : which has to be at the beginning of the BIOS region to be compliant with the : IFWI specification. "we" being who exactly? There is no consent in the coreboot community that I know about.
I would write:
Many custom FMAPs refer to the IFWI as all components of an LBP excluding the OBB.