Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38701 )
Change subject: soc/amd/common/biosram: Add functions to get/set bootram used
......................................................................
Patch Set 4:
Patch Set 4:
What is the motivation to consume non-volatile 8-bit accessible biosram registers here instead of DRAM and migrate these to CBMEM? You need persistent .earlyram.data anyways implemented across early stages.
Adding a small section in .earlyram.data seems acceptable. We'll need to copy that to cbmem in romstage, then use the info stored in cbmem during ramstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38701
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14f5be795803b4cda1a4f0fcb2ee151adb9980a9
Gerrit-Change-Number: 38701
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 02:56:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment