Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34656 )
Change subject: src/soc/intel/cannonlake: Configure top swap based on ucode version ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34656/6/src/soc/intel/cannonlake/bo... File src/soc/intel/cannonlake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/34656/6/src/soc/intel/cannonlake/bo... PS6, Line 36: cpu_id = cpu_get_cpuid(); you don't use cpu_id
https://review.coreboot.org/c/coreboot/+/34656/6/src/soc/intel/cannonlake/bo... PS6, Line 51: G no need for C preprocessor