Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )
Change subject: src/mainboard/google: enable Eotp feature ......................................................................
Patch Set 5:
Patch Set 5:
This flag was added for screen scrolling issue. (CB:41161) Will it introduce screen scrolling issue again if you remove the flag ?
Yes, there is a probability, so we also need to modify the dsi.c
diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c index 73dacef33b..ab24ca4865 100644 --- a/src/soc/mediatek/common/dsi.c +++ b/src/soc/mediatek/common/dsi.c @@ -202,7 +202,7 @@ static void mtk_dsi_config_vdo_timing(u32 mode_flags, u32 format, u32 lanes, data_phy_cycles = phy_timing->lpx + phy_timing->da_hs_prepare + phy_timing->da_hs_zero + phy_timing->da_hs_exit + 3;
- u32 delta = 12; + u32 delta = 14; if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST) delta += 6;