Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46408 )
Change subject: soc/mediatek/mt8192: ufs: Disable reference clock
......................................................................
Patch Set 43:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46408/42/src/soc/mediatek/mt8192/in...
File src/soc/mediatek/mt8192/include/soc/ufs.h:
https://review.coreboot.org/c/coreboot/+/46408/42/src/soc/mediatek/mt8192/in...
PS42, Line 15: (unsigned long)
not sure why we want to cast as ulong here? I think it'd be better no type-casting, or intptr_t ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If11c1b756ad1a0b85f1005f56a6cb4648c687cf0
Gerrit-Change-Number: 46408
Gerrit-PatchSet: 43
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Chaotian Jing
chaotian.jing@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 08:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment