[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: add generic gpio lock mechanism

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58351 )

Change subject: soc/intel/common: add generic gpio lock mechanism
......................................................................

Patch Set 2:

(1 comment)

File src/soc/intel/common/block/smm/smihandler.c:

https://review.coreboot.org/c/coreboot/+/58351/comment/560d4d8d_9a8b5fed 
PS1, Line 380: #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
             : 	/*
             : 	 * Lock down GPIOs controllable by a non-host controller
             : 	 */
             : 	soc_lock_gpios();
             : #endif
> NOTE that I would actally add a __weak soc_gpio_lock_config() (it's been renamed based on a review c […]

#if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS) will conditionally compile the GPIO locking support. Tim's recommendation will compile GPIO locking support always and turn it into a run-time support.

After adding a weak soc_gpio_lock_config() override, Tim's recommendation should work cleanly and you don't need #if scattered around the code.