Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Shuo Liu, Tim Chu, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email )
Change subject: acpi: Add acpigen_write_OSC_pci_domain
......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81375/comment/40761d52_3e5e6d02 :
PS12, Line 11:
Tested how?
File src/acpi/acpigen_pci.c:
https://review.coreboot.org/c/coreboot/+/81375/comment/205da230_cf3044bc :
PS12, Line 98: With
Width
https://review.coreboot.org/c/coreboot/+/81375/comment/54ef3f72_12947749 :
PS12, Line 98: Name - With, Source, Offset, Description
: * --------------------------------
: * QSUP - DWord, Local7, 0x00, Query support
: * RETE - DWord, Arg3, 0x00, Returned errors
: * SUPP - Dword, Arg3, 0x04, PCIe Features that OS supported
: * CTRL - Dword, Arg3, 0x08, PCIe Features that firmware grant control to OS
: * OTRL - Dword, Local7, 0x08, PCIe Features that OS requests for control
: * SUPC - Dword, Arg3, 0x0C, CXL Features that OS supported
: * CTRC - Dword, Arg3, 0x10, CXL Features that firmware grant control to OS
: * OTRC - Dword, Local7, 0x10, CXL Features that OS requests for control
If it’s a table, I wouldn’t separate the columns by a comma.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81375?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I711ce5350d718e47feb2912555108801ad7f918d
Gerrit-Change-Number: 81375
Gerrit-PatchSet: 12
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 26 Mar 2024 11:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment