Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42993 )
Change subject: libpayload: Add simple 32.32 fixed-point math API
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
I would have always thought, the current devices come with corresponding instructions, and the compiler will create fast code (by for example providing lookup tables itself).
https://review.coreboot.org/c/coreboot/+/42993/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42993/2//COMMIT_MSG@14
PS2, Line 14:
It’d be great if you added concrete numbers, how much faster it is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id0f9c23980e36ce0ac0b7c5cd0bc66153bca1fd0
Gerrit-Change-Number: 42993
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 06:09:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment