Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38987 )
Change subject: libpayload: cbgfx: Fix potential overflowing expression
......................................................................
Patch Set 1: Code-Review+2
Thanks for taking care of these!
Patch Set 1:
Coverity found some issues:
CID 1419491: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
We usually add that to the commit message, below Signed-off-by:
Found-by: Coverity Scan #1419491
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd37a6abc01d9fcbcf54525d47b15c9930a9b9fb
Gerrit-Change-Number: 38987
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Feb 2020 12:17:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment