[coreboot-gerrit] Change in coreboot[master]: acpi_table_header: Replace hard-coded revision via macro and function

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35539 )

Change subject: acpi_table_header: Replace hard-coded revision via macro and function
......................................................................

acpi_table_header: Replace hard-coded revision via macro and function

Minimize use of hard-coded value for acpi_table_header->revision to soft
code. Replace with macro defined in arch/acpi.h for FADT and with the
get_acpi_table_revision function for SSDT.

Change-Id: I99e59afc1a87203499d2da6dedaedfa643ca7eac
Signed-off-by: Sourabh Kashyap 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35539
Reviewed-by: Paul Menzel 
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/amd/torpedo/fadt.c
M src/mainboard/portwell/m107/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/lynxpoint/acpi.c
M src/southbridge/nvidia/mcp55/fadt.c
5 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Aaron Durbin: Looks good to me, approved

diff --git a/src/mainboard/amd/torpedo/fadt.c b/src/mainboard/amd/torpedo/fadt.c
index 9e33c07..25fb448 100644
--- a/src/mainboard/amd/torpedo/fadt.c
+++ b/src/mainboard/amd/torpedo/fadt.c
@@ -50,7 +50,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = 244;
-	header->revision = 1;
+	header->revision = ACPI_FADT_REV_ACPI_1_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/mainboard/portwell/m107/fadt.c b/src/mainboard/portwell/m107/fadt.c
index 7814106..82986f6 100644
--- a/src/mainboard/portwell/m107/fadt.c
+++ b/src/mainboard/portwell/m107/fadt.c
@@ -25,7 +25,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 3;
+	header->revision = ACPI_FADT_REV_ACPI_2_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 9515c01..26a1570 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -39,7 +39,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = 244;
-	header->revision = 1;
+	header->revision = ACPI_FADT_REV_ACPI_1_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);
diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c
index 8d4c4e6..83c455f 100644
--- a/src/southbridge/intel/lynxpoint/acpi.c
+++ b/src/southbridge/intel/lynxpoint/acpi.c
@@ -74,7 +74,7 @@
    /* Fill the SSDT header */
    memset((void *)ssdt, 0, sizeof(acpi_header_t));
    memcpy(&ssdt->signature, "SSDT", 4);
-	ssdt->revision = 2;
+	ssdt->revision = get_acpi_table_revision(SSDT);
    memcpy(&ssdt->oem_id, OEM_ID, 6);
    memcpy(&ssdt->oem_table_id, "SERIALIO", 8);
    ssdt->oem_revision = 43;
diff --git a/src/southbridge/nvidia/mcp55/fadt.c b/src/southbridge/nvidia/mcp55/fadt.c
index 6aaa702..9a70ba1 100644
--- a/src/southbridge/nvidia/mcp55/fadt.c
+++ b/src/southbridge/nvidia/mcp55/fadt.c
@@ -39,7 +39,7 @@
    memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
    header->length = sizeof(acpi_fadt_t);
-	header->revision = 1;
+	header->revision = ACPI_FADT_REV_ACPI_1_0;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
    memcpy(header->asl_compiler_id, ASLC, 4);