EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40560 )
Change subject: soc/intel/tigerlake: Check SPD is not NULL before print
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40560/1/src/soc/intel/tigerlake/mem...
File src/soc/intel/tigerlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/40560/1/src/soc/intel/tigerlake/mem...
PS1, Line 311: blk->addr_map[i] && blk->spd_array[i] != NULL
Can you please add a comment here that the SPD gets printed only if: […]
Of course!!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40560
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd9fce99eda7ae2b8fb1b4f3c2e635c2a428f04
Gerrit-Change-Number: 40560
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Apr 2020 16:17:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment