Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41393 )
Change subject: util: add a tool to dump and insert MEC1322 firmware
......................................................................
Patch Set 1:
Nit pick: did you build with clang?
mec1322.c:65:35: warning: format specifies type 'char' but the argument has type 'int' [-Wformat]
printf("SPI clock = %hhd MHz\n", SPI_CLOCK_LIST[hdr->spi_clk]);
~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
%d
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I999bf0289216bf72c4f8f19182c7670d7008b5f9
Gerrit-Change-Number: 41393
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Comment-Date: Sun, 18 Oct 2020 14:15:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment