[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add STXS and CTXS method

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48943 )

Change subject: soc/amd/picasso: Add STXS and CTXS method
......................................................................

Patch Set 2:

(2 comments)
> Patch Set 2:
>
> @AMD, please help review this, I want we can use this in cezanne for guybrush project :)

returned from vacation today and had a brief look. did you test the change on all platforms it might affect?

https://review.coreboot.org/c/coreboot/+/48943/2/src/soc/amd/common/acpi/gpi... 
File src/soc/amd/common/acpi/gpio_bank_lib.asl:

https://review.coreboot.org/c/coreboot/+/48943/2/src/soc/amd/common/acpi/gpi... 
PS2, Line 125: Tx
i'd say that "output" would be much clearer than "tx" here

https://review.coreboot.org/c/coreboot/+/48943/2/src/soc/amd/common/acpi/gpi... 
PS2, Line 139: Tx
same