Felix Held has posted comments on this change. ( https://review.coreboot.org/28618 )
Change subject: util/inteltool: Add Sunrise Point LP
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/28618/5/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:
https://review.coreboot.org/#/c/28618/5/util/inteltool/inteltool.h@144
PS5, Line 144: PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP
0x9d58 should be KabyLake. […]
Yep, that PCI ID is the LPC controller of 7 series (Kabylake) PCH-U Premium. See https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/7th-... page 23 vs. https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/6th-... page 28. Would be good if you'd add support for those different SKUs
--
To view, visit
https://review.coreboot.org/28618
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2454cc11d83a860815bfaab5197c25b29f3384df
Gerrit-Change-Number: 28618
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Johanna Schander
coreboot@mimoja.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 16 Sep 2018 10:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
